Add optional dnsPolicy, dnsConfig to all pods #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
rebased on master |
cognifloyd
force-pushed
the
internal-dns
branch
5 times, most recently
from
d086c1e
to
e37daf9
Compare
cognifloyd
force-pushed
the
internal-dns
branch
2 times, most recently
from
c250d7b
to
5dc5e40
Compare
|
@armab This is straight forward as well and should be quick to review. Thanks again for all your reviews. |
arm4b
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
dnsPolicyanddnsConfigto all pods based on.Values.dnsPolicyand.Values.dnsConfigif defined.I do not think having different
dnsConfig/dnsPolicyper pod makes much sense, so this is provides only one common value for all the pods defined by stackstorm-ha, not one-per-pod like other settings.dnsPolicy: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy
dnsConfig: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config